Skip to content

PostedTransactions: support "WIRE" transaction type#22

Merged
edwagner merged 2 commits intoedwagner:mainfrom
rtsai:posted-transaction-wire
Oct 17, 2025
Merged

PostedTransactions: support "WIRE" transaction type#22
edwagner merged 2 commits intoedwagner:mainfrom
rtsai:posted-transaction-wire

Conversation

@rtsai
Copy link
Copy Markdown

@rtsai rtsai commented Oct 16, 2025

The "WIRE" transaction type is a result of issuing an outbound wire from the checking account.

Similarly to the "ACH" transaction type, map to the "CREDIT" or "DEBIT" transaction type based on whether the transaction is a deposit or withdrawal.

Mapping to "CREDIT" in this PR is done pre-emptively and speculatively; real-world test data is not available to verify/validate this mapping.

Comment thread src/ofxstatement_schwab_json/plugin.py Outdated
"INTADJUST": "INT",
"TRANSFER": "XFER",
"VISA": "POS",
"WIRE": "XFER",
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked "XFER" (similar to "TRANSFER").

Full list of options: https://github.com/edwagner/ofxstatement/blob/c1f060042a0b7ae228d422d53cbac309bdf64147/src/ofxstatement/statement.py#L12-L30

Other candidates:

  • CREDIT / DEBIT for incoming / outgoing wires
  • OTHER

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern with XFER is that wires are often payments which feels different than a transfer between accounts in the same ledger. However I'm certainly no accountant. Personally I like the idea of DEBIT for "Outgoing Wire." Does that seem reasonable to you?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I can use DEBIT for "Outgoing Wire".

I will also use CREDIT for "Incoming Wire" (although I don't have an actual sample for incoming wire to test this). Are you OK with pre-emptively and speculatively using CREDIT in this way (and blindly manufacturing a test case for this)?

Copy link
Copy Markdown
Owner

@edwagner edwagner Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a reasonable speculation, and then we can change it (or add another case) if we discover that it's a different string. Thanks!

@edwagner edwagner merged commit 2b0b422 into edwagner:main Oct 17, 2025
3 checks passed
@rtsai rtsai deleted the posted-transaction-wire branch October 17, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants