Conversation
…ет ошибка, связанная с тем, что в одном из пропсов (modalData) не находится поля, которые используется в одном из элементов. Непонятно, как задать стартовые пропсы, если ошибка только в них.
… (error with functions in props and error with setState in element which removed from VDOM)
….. don't get user's id and calendar's id
|
@DevilRigoll please fix build, see output of travis-ci job |
sergeyt
left a comment
sergeyt
left a comment
There was a problem hiding this comment.
good job, keep it up!
| isSelected: boolean; | ||
| } | ||
|
|
||
| export default class CellCalendar extends React.Component<ICellCalendarProps, {}> { |
There was a problem hiding this comment.
consider renaming to CalendarCell
| switch (this.state.panelId) { | ||
| case FIRST_PANEL: | ||
| obj = | ||
| <tr > |
There was a problem hiding this comment.
lets use CSS flexbox instead of CSS tables
There was a problem hiding this comment.
we can do that in separate PR
|
|
||
| import './style.scss'; | ||
|
|
||
| interface ISeasonView { |
There was a problem hiding this comment.
lets follow the following naming SeasonViewProps, i.e. ComponentName + Props
|
|
||
| const weekday = ['M', 'T', 'W', 'T', 'F', 'S', 'S']; | ||
| /* | ||
| export default class UserCaledarGrid extends React.Component<IUserCalandarGridProps, {}> { |
There was a problem hiding this comment.
lets remove commented code
There was a problem hiding this comment.
git remembers all versions anyway
| } | ||
| ); | ||
| return ( | ||
| <table> |
There was a problem hiding this comment.
lets use CSS flexbox instead of tables
| console.log("DBWorker calendars", calendars); | ||
|
|
||
| console.log("DBWorker members 0",teams[0].members); | ||
| let neededTeamId: string = "Team is not found..."; |
There was a problem hiding this comment.
consider to use id of first team temporarily
|
|
||
| const reducerUserCalendar = handleActions({ | ||
| [setEnterStartDate]: (state, action) => { | ||
| console.log(action.payload); |
There was a problem hiding this comment.
lets user redux-logger instead of console.log
2 participants
No description provided.