Open
Conversation
sespiros
reviewed
Feb 12, 2026
Collaborator
sespiros
left a comment
sespiros
left a comment
There was a problem hiding this comment.
Are you going to add more commits to this or do you want to merge just the packaging for stage0 so that we can experiment?
In any case, some information about how these binaries were built would be helpful as I couldn't find the hashes in oak's repo git log. Do we have custom patches on top somewhere? Also it's not very clear to me how the imposter attribute is meant to be used. My guess is as drop-in replacement to wherever we are pulling OVMF-TDX/SNP?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.