Conversation
Since the `gpu` just deploy target relies on the resourcegen tool, the verdict made in [1] was false. The GPU target is only used in development, so hardcoding the platforms should be fine. [1]: #2030 (comment)
burgerdev
left a comment
There was a problem hiding this comment.
The other commit lgtm. Maybe it makes sense to separate them?
| case platforms.MetalQEMUTDXGPU: | ||
| deviceURI = "nvidia.com/GB100_B200" | ||
| case platforms.MetalQEMUSNPGPU: | ||
| deviceURI = "nvidia.com/GH100_H100_PCIE" |
There was a problem hiding this comment.
I still believe that this is not the right place to configure this. Rather, this should be modelled similar to the tcb-specs.json and be an input to resourcegen.
There was a problem hiding this comment.
How would that work with the just targets? Not saying that it isn't possible, I just wonder what the dataflow would look like.
There was a problem hiding this comment.
While not ideal, we could configure this with a justfile.env var for now, since we're already doing it for the nodeinstaller target config:
Lines 338 to 339 in fb4de83
Eventually, I'd prefer this to be configured in the cluster instead of in the repo, though.
00491da to
b5c9064
Compare
|
Obsolete with #2070 |
Since the
gpujust deploy target relies on the resourcegen tool, the verdict made in 1 was false. The GPU target is only used in development, so hardcoding the platforms should be fine.