Disable JWT authentication on console requests#14
Open
jackatomix wants to merge 2 commits intoedenspiekermann:developfrom
Open
Disable JWT authentication on console requests#14jackatomix wants to merge 2 commits intoedenspiekermann:developfrom
jackatomix wants to merge 2 commits intoedenspiekermann:developfrom
Conversation
jackatomix
changed the title
|
I'm running into this issue too. Manually changing the code using this PR fixes the issue for me. This issue occurred after upgrading to CraftCMS 3.6.3 |
bmenking-wng
approved these changes
Apr 27, 2022
bmenking-wng
left a comment
bmenking-wng
left a comment
There was a problem hiding this comment.
Corrects the error. Tested on CraftCMS 3.5 and 3.6
bmenking-wng
approved these changes
Jan 6, 2023
bmenking-wng
left a comment
bmenking-wng
left a comment
There was a problem hiding this comment.
These changes were tested on 3.7.x and confirmed working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously the plugin would initialize itself on application load. This is fine, but
Craft::$appmay be either acraft\web\Applicationor acraft\console\Application, which are different applications with different use cases.As seen in #11, this would cause all console requests to crash as the console application resolves a console request, and there is no
craft\console\Request::headers.This PR changes the class that the plugin initialzes on from
Craft->$apptocraft\web\Application, causing the plugin to not attempt to authenticate a user based on the current headers on console requests.Definition of Done
composer.jsonis updatedCHANGELOG.mddocumenting changes made