Skip to content

GJ-62 Migrate pytests to new pyfdb API#88

Merged
ChrisspyB merged 1 commit intodevelopfrom
fix/GJ-62-new-pyfdb-api
Mar 30, 2026
Merged

GJ-62 Migrate pytests to new pyfdb API#88
ChrisspyB merged 1 commit intodevelopfrom
fix/GJ-62-new-pyfdb-api

Conversation

@ChrisspyB
Copy link
Copy Markdown
Member

Description

Due to breaking changes in the latest pyfdb API.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.06%. Comparing base (4ba3682) to head (62aa73e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #88      +/-   ##
===========================================
- Coverage    77.90%   77.06%   -0.84%     
===========================================
  Files           97       94       -3     
  Lines         4920     4740     -180     
  Branches       443      443              
===========================================
- Hits          3833     3653     -180     
  Misses        1087     1087              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisspyB
Copy link
Copy Markdown
Member Author

CI failures appear to be caching issues on the runners(?). Will merge to develop, and investigate these failures in a separate PR.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pygribjump pytest suite to accommodate breaking changes in the latest pyfdb Python API.

Changes:

  • Adapt pyfdb.FDB.archive() test usage to the updated call signature (no key= keyword).
  • Update pyfdb.FDB.list() test usage to iterate over returned elements and extract uri/offset via the new accessors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ChrisspyB ChrisspyB merged commit fc51096 into develop Mar 30, 2026
136 of 139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants