GJ-62 Migrate pytests to new pyfdb API#88
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #88 +/- ##
===========================================
- Coverage 77.90% 77.06% -0.84%
===========================================
Files 97 94 -3
Lines 4920 4740 -180
Branches 443 443
===========================================
- Hits 3833 3653 -180
Misses 1087 1087 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
CI failures appear to be caching issues on the runners(?). Will merge to develop, and investigate these failures in a separate PR. |
There was a problem hiding this comment.
Pull request overview
Updates the pygribjump pytest suite to accommodate breaking changes in the latest pyfdb Python API.
Changes:
- Adapt
pyfdb.FDB.archive()test usage to the updated call signature (nokey=keyword). - Update
pyfdb.FDB.list()test usage to iterate over returned elements and extracturi/offsetvia the new accessors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to breaking changes in the latest pyfdb API.
Contributor Declaration
By opening this pull request, I affirm the following: