Skip to content

Fix link stats#2521

Merged
OlivierHecart merged 2 commits intomainfrom
fix/link_stats
Mar 26, 2026
Merged

Fix link stats#2521
OlivierHecart merged 2 commits intomainfrom
fix/link_stats

Conversation

@OlivierHecart
Copy link
Copy Markdown
Contributor

@OlivierHecart OlivierHecart commented Mar 25, 2026

Description

This PR fixes a bug in link stats that caused link stats to be wrongly set to 0 in json reports.

What does this PR do?

Tis PR registers links in the stats registers with their complete src and dst locators including parameters.
Ex: tcp/1.1.1.1:1?prio=1 instead of only tcp/1.1.1.1:1.
This is needed as the links are then looked up with their complete locators when building the report.

Why is this change needed?

This fixes the json stats report.


🏷️ Label-Based Checklist

Based on the labels applied to this PR, please complete these additional requirements:

Labels: bug

🐛 Bug Fix Requirements

Since this PR is labeled as a bug fix, please ensure:

  • Root cause documented - Explain what caused the bug in the PR description
  • Reproduction test added - Test that fails on main branch without the fix
  • Test passes with fix - The reproduction test passes with your changes
  • Regression prevention - Test will catch if this bug reoccurs in the future
  • Fix is minimal - Changes are focused only on fixing the bug
  • Related bugs checked - Verified no similar bugs exist in related code

Why this matters: Bugs without tests often reoccur.

Instructions:

  1. Check off items as you complete them (change - [ ] to - [x])
  2. The PR checklist CI will verify these are completed

This checklist updates automatically when labels change, but preserves your checked boxes.

@OlivierHecart OlivierHecart added the bug Something isn't working label Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.53%. Comparing base (ec069a9) to head (f1c2cba).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2521   +/-   ##
=======================================
  Coverage   72.53%   72.53%           
=======================================
  Files         390      390           
  Lines       63376    63376           
=======================================
+ Hits        45969    45972    +3     
+ Misses      17407    17404    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OlivierHecart OlivierHecart merged commit 2f403d4 into main Mar 26, 2026
57 of 58 checks passed
@OlivierHecart OlivierHecart deleted the fix/link_stats branch March 26, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants