Account for declared ke in Query::reply #2387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisBiryukov91
changed the title
DenisBiryukov91
force-pushed
the
reply-use-declared-ke
branch
from
50cbe07 to
5dd9557
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
+ Coverage 72.01% 72.02% +0.01%
==========================================
Files 390 390
Lines 62792 62820 +28
==========================================
+ Hits 45217 45246 +29
+ Misses 17575 17574 -1 ☔ View full report in Codecov by Sentry. |
OlivierHecart
approved these changes
Jan 28, 2026
Contributor
|
Failing tests are independent from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Account for declared ke in Query::reply
What does this PR do?
If declared ke is passed to Query::reply, the optimization will be taken into account, instead of completely unwrapping ke string.
Why is this change needed?
Removes unnecessary copy of ke string in Query::reply if ke is fully optimized (this is in particular always the case for advanced publisher cache).
Related Issues
None
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
internal🏠 Internal Change
This PR is marked as internal (not user-facing):
Lighter review: Internal changes may have lighter review requirements.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.