Skip to content

Conversation

@wyfo
Copy link
Contributor

@wyfo wyfo commented Jan 20, 2026

Description

See title

What does this PR do?

Force the response QoS to the original query QoS. Setting the QoS (except express) of the response is deprecated and disabled.

Why is this change needed?

Having multiple QoS for responses, especially for ResponseFinal, could cause priority inversion in response handling, causing responses to be lost.

Related Issues

https://zettascale.atlassian.net/browse/ZEN-860


🏷️ Label-Based Checklist

Based on the labels applied to this PR, please complete these additional requirements:

Labels: enhancement

✨ Enhancement Requirements

Since this PR enhances existing functionality:

  • Enhancement scope documented - Clear description of what is being improved
  • Minimum necessary code - Implementation is as simple as possible, doesn't overcomplicate the system
  • Backwards compatible - Existing code/APIs still work unchanged
  • No new APIs added - Only improving existing functionality
  • Tests updated - Existing tests pass, new test cases added if needed
  • Performance improvement measured - If applicable, before/after metrics provided
  • Documentation updated - Existing docs updated to reflect improvements
  • User impact documented - How users benefit from this enhancement

Remember: Enhancements should not introduce new APIs or breaking changes.

Instructions:

  1. Check off items as you complete them (change - [ ] to - [x])
  2. The PR checklist CI will verify these are completed

This checklist updates automatically when labels change, but preserves your checked boxes.

@wyfo wyfo added bug Something isn't working enhancement Existing things could work better and removed bug Something isn't working labels Jan 20, 2026
@wyfo wyfo requested a review from OlivierHecart January 20, 2026 10:40
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.96%. Comparing base (3c77c34) to head (5a6e996).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
zenoh/src/api/builders/reply.rs 42.85% 4 Missing ⚠️
zenoh/src/net/primitives/mux.rs 50.00% 2 Missing ⚠️
zenoh/src/net/routing/dispatcher/queries.rs 83.33% 2 Missing ⚠️
zenoh/src/net/routing/interceptor/qos_overwrite.rs 0.00% 1 Missing ⚠️
zenoh/src/net/runtime/adminspace.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
+ Coverage   71.91%   71.96%   +0.05%     
==========================================
  Files         390      390              
  Lines       62764    62800      +36     
==========================================
+ Hits        45139    45197      +58     
+ Misses      17625    17603      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wyfo
Copy link
Contributor Author

wyfo commented Jan 21, 2026

CI is failing because I'm adding a #[deprecated] attribute, and we have CARGO_SEMVER_CHECKS_RELEASE_TYPE: patch in the CI.
@diogomatsubara It's wrong to block the CI like this, preventing to merge necessary minor changes. Could we refine the semver check? For example, adding a "minor" label, and change the semver check according to its presence? Of course, the CI for main branch would always have it set to minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Existing things could work better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant