Skip to content

Store slice instead of range in ZSlice#2379

Open
wyfo wants to merge 4 commits intoeclipse-zenoh:mainfrom
ZettaScaleLabs:zslice-slice
Open

Store slice instead of range in ZSlice#2379
wyfo wants to merge 4 commits intoeclipse-zenoh:mainfrom
ZettaScaleLabs:zslice-slice

Conversation

@wyfo
Copy link
Contributor

@wyfo wyfo commented Jan 20, 2026

Dynamic dispatch of ZSliceBuffer::as_slice was hurting deserialization performance.


🏷️ Label-Based Checklist

Based on the labels applied to this PR, please complete these additional requirements:

Labels: internal

🏠 Internal Change

This PR is marked as internal (not user-facing):

  • No API changes - Public APIs unchanged
  • No behavior changes - External behavior identical
  • Refactoring/maintenance - Code improvements only
  • Tests still pass - All existing tests pass without modification

Lighter review: Internal changes may have lighter review requirements.

Instructions:

  1. Check off items as you complete them (change - [ ] to - [x])
  2. The PR checklist CI will verify these are completed

This checklist updates automatically when labels change, but preserves your checked boxes.

@wyfo wyfo added the internal Changes not included in the changelog label Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 95.65217% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.96%. Comparing base (3c77c34) to head (dfc3e3e).

Files with missing lines Patch % Lines
commons/zenoh-buffers/src/zslice.rs 95.38% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2379      +/-   ##
==========================================
+ Coverage   71.91%   71.96%   +0.04%     
==========================================
  Files         390      390              
  Lines       62764    62810      +46     
==========================================
+ Hits        45139    45203      +64     
+ Misses      17625    17607      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes not included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant