Provide the context of the interaction when reporting client requests and HTTP requests. #5826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
http-request-context-for-metrics
branch
from
cfda4e0 to
7b96d53
Compare
… and HTTP requests. Motivation: The metrics SPI before the tracing SPI, it does not take in account the request context unlike the tracing SPI. We can definitely introduce its support by passing the context as part of the metrics SPI event signal. Changes: - Overload appropriate metrics SPI events with a signature augmented with the Vert.x context - Deprecate for removal in Vertx 6.0 the original versions - Implement and test the behavior
vietj
force-pushed
the
http-request-context-for-metrics
branch
from
7b96d53 to
34f19ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The metrics SPI before the tracing SPI, it does not take in account the request context unlike the tracing SPI. We can definitely introduce its support by passing the context as part of the metrics SPI event signal.
Changes: