fix: prevent duplicate VSIX installations by using package.json ident…#16963
Open
rajj28 wants to merge 2 commits intoeclipse-theia:masterfrom
Open
fix: prevent duplicate VSIX installations by using package.json ident…#16963rajj28 wants to merge 2 commits intoeclipse-theia:masterfrom
rajj28 wants to merge 2 commits intoeclipse-theia:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #16845 - Prevents duplicate VSIX extension installations when the same extension is installed from VSIX files with different filenames.
Problem: Extensions installed via "Install from VSIX..." were identified by their filename rather than the actual extension identity from
package.json. This allowed the same extension to be installed multiple times by simply renaming the VSIX file, resulting in:deployedPluginsSolution: Extract the true extension identity (
publisher.name@version) from the VSIX's embeddedextension/package.jsoninstead of deriving it from the filename.Changes:
extractExtensionIdentityFromVsix()function inplugin-vscode-utils.tsthat reads publisher, name, and version from the VSIX's package.jsonLocalVSIXFilePluginDeployerResolver.resolveFromLocalPath()to:getDeployedPluginsById()to block duplicate installations of the same extensionHow to test
Extensions: Install from VSIX...hello-0.0.1.vsix→hello-renamed.vsix)Extensions: Install from VSIX...deployedPluginsFollow-ups
Breaking changes
Attribution
Review checklist