Update Color constructors to modern signature#3888
Update Color constructors to modern signature#3888vogella merged 3 commits intoeclipse-platform:masterfrom
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Follows eclipse-platform/eclipse.platform.swt#3232 by removing the Device/Display argument from Color constructors.
There was a problem hiding this comment.
Pull request overview
This PR updates SWT Color instantiations across UI code, tests, and examples to match the modern constructor signatures (no Device/Display argument), aligning with eclipse-platform SWT issue #3232.
Changes:
- Replace
new Color(deviceOrDisplay, ...)withnew Color(...)(RGB/RGBA or r/g/b[/a]) across bundles, tests, and examples. - Remove now-unneeded
Displayimports/locals in several classes. - Bump bundle versions for affected example plugins.
Reviewed changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/extension/TestLabelProvider.java | Update Color construction to new signature in test utility. |
| tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/util/ImageHyperlinkTest.java | Update gradient color construction in tests. |
| tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/util/FormImagesTest.java | Update many Color constructions used by gradient image tests. |
| tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/util/FlatLookTest.java | Update Color constructions used by flat/gradient rendering tests. |
| tests/org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests/contributions/ThePresentationReconcilerRed.java | Remove Display import and update Color(RGB) construction. |
| tests/org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests/contributions/ThePresentationReconcilerGreen.java | Remove Display import and update Color(RGB) construction. |
| tests/org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests/contributions/ThePresentationReconcilerBlue.java | Remove Display import and update Color(RGB) construction. |
| tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/TextPresentationTest.java | Update helper to create Color without display argument. |
| tests/org.eclipse.jface.tests/src/org/eclipse/jface/tests/widgets/TestUnitControlFactory.java | Update test colors from Color(null, …) to new signature. |
| tests/org.eclipse.jface.tests/src/org/eclipse/jface/tests/viewers/TableColorProviderTest.java | Remove Display import usage; update test colors. |
| tests/org.eclipse.jface.tests/src/org/eclipse/jface/tests/images/ResourceManagerTest.java | Update RGB-based Color construction in test setup. |
| tests/org.eclipse.e4.ui.tests.css.swt/tkuiTestsToRefactor/swt/test/org/akrogen/tkui/css/swt/serializers/CSSSerializerSWTTest.java | Update test resource color construction. |
| tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/InheritTest.java | Update Color(RGB) construction in test setup. |
| examples/org.eclipse.ui.examples.javaeditor/Template Editor Example/org/eclipse/ui/examples/templateeditor/editors/ColorManager.java | Remove Display import; update cached color creation. |
| examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF | Version bump to reflect API-impacting change usage. |
| examples/org.eclipse.ui.examples.javaeditor/Eclipse Java Editor Example/org/eclipse/ui/examples/javaeditor/util/JavaColorProvider.java | Remove Display import; update cached color creation. |
| examples/org.eclipse.jface.text.examples/src/org/eclipse/jface/text/examples/sources/inlined/InlinedAnnotationDemo.java | Update parsing to new Color(r,g,b) (leaves Device param unused). |
| examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/window/Snippet031TableStaticTooltip.java | Update snippet image-color creation. |
| examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet061FakedNativeCellEditor.java | Update snippet “greenscreen” color creation. |
| examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet051TableCenteredImage.java | Update snippet image-color creation. |
| examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet046UpdateViewerFromBackgroundThread.java | Update snippet image-color creation. |
| examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet003TableLabelProvider.java | Update snippet image-color creation. |
| examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/snippets/Snippet007ColorLabelProvider.java | Update example label provider color creation. |
| examples/org.eclipse.jface.examples.databinding/META-INF/MANIFEST.MF | Version bump to reflect change usage. |
| bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/splash/BasicSplashHandler.java | Update foreground color creation for splash handler. |
| bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/statushandlers/SupportTray.java | Update hot background Color(RGB) construction. |
| bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/ShowViewDialog.java | Update dimmed foreground Color(RGB) construction. |
| bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/HeapStatus.java | Update heap status colors to new signature. |
| bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/FilteredTableBaseHandler.java | Update separator background color construction in image drawer. |
| bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/InfoForm.java | Update separator color construction. |
| bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java | Update preference-based color creation helper; remove display parameter. |
| bundles/org.eclipse.ui.forms/src/org/eclipse/ui/internal/forms/widgets/FormImages.java | Update internal image descriptor color creation to new signature. |
| bundles/org.eclipse.ui.forms/src/org/eclipse/ui/forms/widgets/Hyperlink.java | Update disabled-foreground blend Color(RGB) construction. |
| bundles/org.eclipse.ui.editors/src/org/eclipse/ui/internal/texteditor/SourceViewerInformationControl.java | Update status text blended foreground Color(RGB) construction. |
| bundles/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/TextEditorDefaultsPreferencePage.java | Update color preview image color construction. |
| bundles/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/SharedTextColors.java | Update cached color creation to new signature. |
| bundles/org.eclipse.jface/src/org/eclipse/jface/resource/RGBColorDescriptor.java | Update descriptor color creation to new signature. |
| bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ColorRegistry.java | Update registry color creation to new signature. |
| bundles/org.eclipse.jface/src/org/eclipse/jface/preference/ColorSelector.java | Update selector image rendering color creation to new signature. |
| bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/FieldAssistColors.java | Update computed required-field color creation. |
| bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/TitleAreaDialog.java | Update title area color creation to new signature. |
| bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/PopupDialog.java | Update info-text blended foreground Color(RGB) construction. |
| bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/hyperlink/DefaultHyperlinkPresenter.java | Update hyperlink color creation to new signature. |
| bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/AbstractInformationControl.java | Update status-label blended foreground Color(RGB) construction. |
| bundles/org.eclipse.jface.text/projection/org/eclipse/jface/text/source/projection/SourceViewerInformationControl.java | Update status text blended foreground Color(RGB) construction. |
| bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/CSSRenderingUtils.java | Update helper color creation to new signature. |
| bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java | Update gradient-line Color(RGB) construction. |
| bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/GradientBackgroundListener.java | Update gradient listener per-stop color creation (RGB/RGBA). |
| bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/helpers/CSSSWTColorHelper.java | Update CSS→SWT color creation (now Display argument usage is inconsistent). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Follows eclipse-platform/eclipse.platform.swt#3232 by removing the Device/Display argument from Color constructors.
Follows eclipse-platform/eclipse.platform.swt#3232 by removing the Device/Display argument from Color constructors.