Set compiler.problem.forbiddenReference to error for all projects#3762
Merged
laeubi merged 2 commits intoeclipse-platform:masterfrom Mar 7, 2026
Merged
Conversation
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Test Results 852 files - 2 172 852 suites - 2 172 53m 46s ⏱️ - 1h 24m 33s Results for commit ebd74bc. ± Comparison against base commit c5f3a58. This pull request removes 6328 and adds 5936 tests. Note that renamed tests count towards both.This pull request removes 119 skipped tests and adds 119 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
If it's not already an error.
HannesWell
force-pushed
the
forbiddenReference-as-error
branch
from
8c499f7 to
a94ff4e
Compare
HannesWell
commented
Mar 7, 2026
| Bundle-Vendor: Eclipse.org | ||
| Import-Package: org.junit.jupiter.api;version="[5.14.0,6.0.0)", | ||
| org.junit.jupiter.api.function;version="[5.14.0,6.0.0)", | ||
| org.junit.jupiter.api.io;version="[5.14.0,6.0.0)", |
Member
Author
There was a problem hiding this comment.
And we have our first missing dependency.
Without it, the @TempDir annotation cannot be used in:
The reason why this didn't surface at runtime, is probably because Annotations whose class cannot be loaded, are just silently ignored.
But the creation/clean-up of that directory certainly wouldn't have worked.
'Luckily' the referencing tests are disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If it's not already an error.
See