Don't update setting when session is closing - #247
Merged
jreineckearm merged 2 commits intoJul 29, 2026
Conversation
omarArm
force-pushed
the
highlightingCleanUp
branch
from
July 29, 2026 12:00
13e455f to
f106a3d
Compare
jreineckearm
changed the title
Contributor
|
The two issues are fixed with this. But now we are back to seeing |
omarArm
force-pushed
the
highlightingCleanUp
branch
from
July 29, 2026 13:05
5cbbc33 to
e3d1a82
Compare
jreineckearm
approved these changes
Jul 29, 2026
jreineckearm
left a comment
jreineckearm
left a comment
Contributor
There was a problem hiding this comment.
Thanks, tested various cases
- switching between multi-core sessions.
- different starting points (entry in settings.json present, false, true)
- using debug connections that are not
gdbandgdbtarget.
No more unexpected writing of settings.json, context menu entry carries the correct text (i.e. the highlighted context is not correctly updated). I believe we have this now under control.
Approved, will merge soon. Tempted to make a patch release out of this because it still affects users that don't actively use gdbtarget/gdb adapters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a debug session is shutting down, settings.json should not be updated again. Instead, the latest setting should remain as is
Fixes: #243 and #244