ray: simplify nan checking by creating a macro.#225
Merged
ebassi merged 1 commit intoebassi:masterfrom Jun 6, 2021
ericonr:isnan
Merged
ray: simplify nan checking by creating a macro.#225ebassi merged 1 commit intoebassi:masterfrom ericonr:isnan
ebassi merged 1 commit intoebassi:masterfrom
ericonr:isnan
Conversation
Contributor
|
Be aware of this comment: #174 (comment) |
Contributor
Author
|
@Gottox I am still using |
mixi
reviewed
Apr 12, 2021
Contributor
Author
|
Ping? |
Avoids the #ifdef forest and code duplication resulting from it.
There was mismatch in the two code paths, see [1] and [2], and this
commit avoids repeating the same mistake.
While there, use isnan() instead of fpclassify() == FP_NAN for the case
where isnanf() isn't available.
We use isnanf() (if available) instead of isnan() due to [3]:
I initially used isinf() and isnan(), but those ended up breaking
when using GCC because it tried to promote floats to doubles, and
the results wouldn't match any more—especially when using GCC
vectorisation.
It could very well be a bug in GCC.
[1] #223
[2] https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3976
[3] #174 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids the #ifdef forest and code duplication resulting from it.
There was mismatch in the two code paths, see [1] and [2], and this
commit avoids repeating the same mistake.
[1] #223
[2] https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3976
Fixes #223