Skip to content

{bio}[GCCcore/14.2.0] SvABA 1.3.0#25561

Merged
smoors merged 2 commits intoeasybuilders:developfrom
fizwit:20260313123143_new_pr_SvABA130
Apr 8, 2026
Merged

{bio}[GCCcore/14.2.0] SvABA 1.3.0#25561
smoors merged 2 commits intoeasybuilders:developfrom
fizwit:20260313123143_new_pr_SvABA130

Conversation

@fizwit
Copy link
Copy Markdown
Contributor

@fizwit fizwit commented Mar 13, 2026

(created using eb --new-pr)

@PhoenixEmik name changed

Is there a better way to implement the files_to_copy? There are some helper shell scripts from the source directory that should be copied to 'bin'.

How can a PR be updated if the directory name changes?

@github-actions github-actions bot added 2025a issues & PRs related to 2025a common toolchains new labels Mar 13, 2026
@PhoenixEmik
Copy link
Copy Markdown
Contributor

PhoenixEmik commented Mar 18, 2026

Maybe just use %(namelower)s instead of f'{name.lower()}'?
I uploaded a modified easyconfig for our internal use, originally created by you:
https://github.com/CPOS-HPC/easybuild-easyconfigs/blob/cpos/easybuild/easyconfigs/s/SvABA/SvABA-1.3.0-GCCcore-13.3.0.eb

@fizwit
Copy link
Copy Markdown
Contributor Author

fizwit commented Mar 18, 2026

I've switchedf to using f-strings, because I see that as a trend in newer EasyConfigs that I use. The %-style formatting is still valid Python but generally considered legacy at this point. But I'm not sure why f'{name lower}' does not work. namelower is listed in the template values.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Apr 8, 2026

we should use the easybuild templates when available, and only fall back to f-strings if not available.

EDIT: done in 75c425a

@smoors smoors self-assigned this Apr 8, 2026
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Apr 8, 2026

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25561 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25561 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10156

Test results coming soon (I hope)...

Details

- notification for comment with ID 4205191784 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (total: 1 min 45 secs) (1 easyconfigs in total)
jsczen3c3.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/7c5eb7b4ad7f8a14a21918120d1191f7 for a full test report.

@smoors smoors added this to the next release (5.3.0) milestone Apr 8, 2026
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Apr 8, 2026

Going in, thanks @fizwit!

@smoors smoors merged commit 0619707 into easybuilders:develop Apr 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2025a issues & PRs related to 2025a common toolchains new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants