Skip to content

require setting sanity_pip_list for new PRs#25112

Closed
smoors wants to merge 1 commit intoeasybuilders:developfrom
smoors:sanity_pip_list
Closed

require setting sanity_pip_list for new PRs#25112
smoors wants to merge 1 commit intoeasybuilders:developfrom
smoors:sanity_pip_list

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Jan 21, 2026

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 28, 2026

@smoors Before we require this, we should update a couple of easyconfigs (like recent Python, Python-bundle-PyPI, SciPy-bundle, matplotlib, etc.) to make sure that there's no problems already with these?

@boegel boegel added this to the next release (5.2.1?) milestone Jan 28, 2026
@boegel boegel changed the title require setting sanity_pip_list for new PRs require setting sanity_pip_list for new PRs Jan 28, 2026
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Jan 28, 2026

@smoors Before we require this, we should update a couple of easyconfigs (like recent Python, Python-bundle-PyPI, SciPy-bundle, matplotlib, etc.) to make sure that there's no problems already with these?

unlike sanity_pip_check, this only checks for extensions listed in the easyconfig that has sanity_pip_list = True set, so there is no rush to fix existing easyconfigs. but indeed would be good to fix the common ones to avoid surprises during updates.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 28, 2026

@smoors Before we require this, we should update a couple of easyconfigs (like recent Python, Python-bundle-PyPI, SciPy-bundle, matplotlib, etc.) to make sure that there's no problems already with these?

unlike sanity_pip_check, this only checks for extensions listed in the easyconfig that has sanity_pip_list = True set, so there is no rush to fix existing easyconfigs. but indeed would be good to fix the common ones to avoid surprises during updates.

No rush indeed, but having some idea of how large the impact would be if we start requiring this would be good...

@boegel boegel modified the milestones: next release (5.2.1), 5.x Feb 18, 2026
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Feb 27, 2026

this is no longer needed as we will do the check as part of sanity_pip_check

@smoors smoors closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants