Skip to content

{lib}[GCC/13.2.0,GCCcore/13.2.0,intel-compilers/2023.2.1] Fortran-stdlib v0.7.0, fypp v3.2#21904

Open
SimonPinches wants to merge 3 commits intoeasybuilders:developfrom
SimonPinches:20241123173925_new_pr_Fortran-stdlib070
Open

{lib}[GCC/13.2.0,GCCcore/13.2.0,intel-compilers/2023.2.1] Fortran-stdlib v0.7.0, fypp v3.2#21904
SimonPinches wants to merge 3 commits intoeasybuilders:developfrom
SimonPinches:20241123173925_new_pr_Fortran-stdlib070

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

…b-0.7.0-intel-compilers-2023.2.1.eb, fypp-3.2-GCCcore-13.2.0.eb
@github-actions
Copy link
Copy Markdown

Updated software Fortran-stdlib-0.7.0-GCC-13.2.0.eb

Diff against Fortran-stdlib-0.7.0-intel-compilers-2023.2.1.eb

easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-intel-compilers-2023.2.1.eb

diff --git a/easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-intel-compilers-2023.2.1.eb b/easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-GCC-13.2.0.eb
index b272e9de9c..13a1094e0a 100644
--- a/easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-intel-compilers-2023.2.1.eb
+++ b/easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-GCC-13.2.0.eb
@@ -6,7 +6,7 @@ version = '0.7.0'
 homepage = 'https://awvwgk.github.io/stdlib-docs/en/index.html'
 description = """Community driven and agreed upon de facto "standard" library for Fortran"""
 
-toolchain = {'name': 'intel-compilers', 'version': '2023.2.1'}
+toolchain = {'name': 'GCC', 'version': '13.2.0'}
 toolchainopts = {}  # toolchain options, e.g. opt, pic, usempi, optarch, ...
 
 source_urls = ['https://github.com/fortran-lang/stdlib/archive/refs/tags/']
@@ -22,8 +22,7 @@ builddependencies = [
 configopts = '-DBUILD_SHARED_LIBS=on '
 
 sanity_check_paths = {
-    'files': ['include/fortran_stdlib/Intel-2021.10.0.20230609/stdlib_version.mod',
-              'lib/libfortran_stdlib.%s' % SHLIB_EXT],
+    'files': ['include/fortran_stdlib/GNU-13.2.0/stdlib_version.mod', 'lib/libfortran_stdlib.%s' % SHLIB_EXT],
     'dirs': ['include', 'lib', 'share'],
 }
 

Updated software Fortran-stdlib-0.7.0-intel-compilers-2023.2.1.eb

Diff against Fortran-stdlib-0.7.0-GCC-13.2.0.eb

easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-GCC-13.2.0.eb

diff --git a/easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-GCC-13.2.0.eb b/easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-intel-compilers-2023.2.1.eb
index 13a1094e0a..b272e9de9c 100644
--- a/easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-GCC-13.2.0.eb
+++ b/easybuild/easyconfigs/f/Fortran-stdlib/Fortran-stdlib-0.7.0-intel-compilers-2023.2.1.eb
@@ -6,7 +6,7 @@ version = '0.7.0'
 homepage = 'https://awvwgk.github.io/stdlib-docs/en/index.html'
 description = """Community driven and agreed upon de facto "standard" library for Fortran"""
 
-toolchain = {'name': 'GCC', 'version': '13.2.0'}
+toolchain = {'name': 'intel-compilers', 'version': '2023.2.1'}
 toolchainopts = {}  # toolchain options, e.g. opt, pic, usempi, optarch, ...
 
 source_urls = ['https://github.com/fortran-lang/stdlib/archive/refs/tags/']
@@ -22,7 +22,8 @@ builddependencies = [
 configopts = '-DBUILD_SHARED_LIBS=on '
 
 sanity_check_paths = {
-    'files': ['include/fortran_stdlib/GNU-13.2.0/stdlib_version.mod', 'lib/libfortran_stdlib.%s' % SHLIB_EXT],
+    'files': ['include/fortran_stdlib/Intel-2021.10.0.20230609/stdlib_version.mod',
+              'lib/libfortran_stdlib.%s' % SHLIB_EXT],
     'dirs': ['include', 'lib', 'share'],
 }
 

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Nov 23, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=21904 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21904 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14760

Test results coming soon (I hope)...

Details

- notification for comment with ID 2495583838 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f0e78bf7a6748ee44a504a5e3d870d9f for a full test report.

@Thyre Thyre added the 2023b label Aug 18, 2025
@github-actions github-actions bot removed the update label Apr 8, 2026
description = """Community driven and agreed upon de facto "standard" library for Fortran"""

toolchain = {'name': 'GCC', 'version': '13.2.0'}
toolchainopts = {} # toolchain options, e.g. opt, pic, usempi, optarch, ...
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this since it's empty

Comment on lines +17 to +19
use_pip = True
download_dep_fail = True
sanity_pip_check = True
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop these since they are the default

('fypp', '3.2'),
]

configopts = '-DBUILD_SHARED_LIBS=on '
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use build_shared_libs=True instead of this.

('fypp', '3.2'),
]

configopts = '-DBUILD_SHARED_LIBS=on '
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use build_shared_libs=True instead of this.

configopts = '-DBUILD_SHARED_LIBS=on '

sanity_check_paths = {
'files': ['include/fortran_stdlib/Intel-2021.10.0.20230609/stdlib_version.mod',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird path that would need to be manually specified to the compiler to be found.
It should be moved to just include/fortran_stdlib or more likely just include if we want other packages to find it automatically.

sanity_check_paths = {
'files': ['include/fortran_stdlib/Intel-2021.10.0.20230609/stdlib_version.mod',
'lib/libfortran_stdlib.%s' % SHLIB_EXT],
'dirs': ['include', 'lib', 'share'],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include and lib can be dropped since they are implicit by the files directive

Comment on lines +25 to +26
'files': ['include/fortran_stdlib/GNU-13.2.0/stdlib_version.mod', 'lib/libfortran_stdlib.%s' % SHLIB_EXT],
'dirs': ['include', 'lib', 'share'],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in the intel version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants