Skip to content

{tools}[gfbf/2023b] JPype v1.5.0#19880

Merged
akesandgren merged 10 commits intoeasybuilders:developfrom
SimonPinches:20240216173355_new_pr_JPype1150
Apr 8, 2026
Merged

{tools}[gfbf/2023b] JPype v1.5.0#19880
akesandgren merged 10 commits intoeasybuilders:developfrom
SimonPinches:20240216173355_new_pr_JPype1150

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

@SimonPinches SimonPinches commented Feb 16, 2024

(created using eb --new-pr)

This PR depends upon

@SimonPinches
Copy link
Copy Markdown
Contributor Author

Depends upon PR #19620.

Could also be renamed to Jpype rather that Jpype1 (which is the name still used on PyPi) which would seem more natural.

@boegelbot

This comment was marked as outdated.

@sassy-crick
Copy link
Copy Markdown
Collaborator

@SimonPinches You might want to sync your PR with development, something like this:

eb --sync-pr-with-develop NUMBER_OF_PR

dependencies = [
('Python', '3.11.5'),
('SciPy-bundle', '2023.11'),
('Java', '21', '', SYSTEM),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonPinches Does this really need Java/21?

For the 2023b generation, we usually stick with Java/11...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel Some of our applications need Java/21 as remarked here in PR #20945. It is also the recommended LTS version (see https://whichjdk.com/).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make an exception to this, but you're swimming upstream a bit for this generation of easyconfigs...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've added an exception which shouldn't be needed when we move to using the new 2025b toolchains :-)

@SimonPinches SimonPinches changed the title {tools}[gfbf/2023b] JPype1 v1.5.0 {tools}[gfbf/2023b] JPype v1.5.0 Jul 3, 2025
@akesandgren
Copy link
Copy Markdown
Contributor

@boegelbot Please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@akesandgren: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19880 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19880 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10149

Test results coming soon (I hope)...

Details

- notification for comment with ID 4204954561 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (total: 2 mins 36 secs) (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/cc6c4e2d37236a393b35b9c081a97efa for a full test report.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren added this to the next release (5.3.0) milestone Apr 8, 2026
@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @SimonPinches!

@akesandgren akesandgren merged commit abe3125 into easybuilders:develop Apr 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants