{data}[GCCcore/13.2.0] MDSplus v7.132.0

[SimonPinches]

(created using eb --new-pr)

[boegelbot]

@SimonPinches: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/7389075026
Output from first failing test suite run:

FAIL: test__parse_easyconfig_MDSplus-7.132.0-GCCcore-13.2.0.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for easyconfig MDSplus-7.132.0-GCCcore-13.2.0.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1607, in innertest
    template_easyconfig_test(self, spec_path)
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1582, in template_easyconfig_test
    self.fail(error_msg)
AssertionError: use of `True` to indicate the system toolchain for dependency Java is deprecated, use the `SYSTEM` template constant instead

----------------------------------------------------------------------
Ran 18772 tests in 669.223s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

[akesandgren]

Please add description and author/date info to the patch (and update checksums)

[SimonPinches]

Thanks @akesandgren, I've added a very brief description to the patch and updated as you suggested.

[akesandgren]

@boegelbot Please test @ generoso

[boegelbot]

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=19472 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19472 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

• exit code: 0
• output:

Submitted batch job 12514

Test results coming soon (I hope)...

Details

- notification for comment with ID 1878566654 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

[boegelbot]

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/28cbb1bd49a267b391bd7f4cafa6b315 for a full test report.

[akesandgren]

Since this is pulled down using git_config it will not have a stable checksum.
I.e. you need to change it to

{'mdsplus-7.132.0.tar.gz': None},

But I'm not sure if we've manged to fix the bugs we had in framework regarding this.

It would be better to pull down the https://github.com/MDSplus/mdsplus/archive/refs/tags/stable_release-7-132-0.tar.gz file and the corresponding version of https://github.com/MDSplus/3rd-party-apis.git unfortunately it doesn't have releases, so the problem will remain...

[SimonPinches]

Thanks @akesandgren, this is good to know! I've updated the EB file to reflect this. I had to change the syntax slightly since --check-style wasn't happy with what you proposed.

[boegelbot]

@SimonPinches: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/7422905875
Output from first failing test suite run:

ERROR: test__parse_easyconfig_MDSplus-7.132.0-GCCcore-13.2.0.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for easyconfig MDSplus-7.132.0-GCCcore-13.2.0.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1607, in innertest
    template_easyconfig_test(self, spec_path)
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1464, in template_easyconfig_test
    res = verify_checksum(patch_full, checksum)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/filetools.py", line 1303, in verify_checksum
    checksum)
easybuild.tools.build_log.EasyBuildError: "Invalid checksum spec '['7', 'c', '4', '0', 'e', 'd', 'c', '8', '4', '7', '3', '7', 'd', 'd', 'b', '8', 'f', '7', '8', '5', 'b', 'd', 'c', '3', 'b', '8', '8', '6', '0', '4', 'a', '1', '6', 'e', 'c', 'd', '1', '6', 'f', '3', '8', 'b', '3', '1', '3', '0', '9', '8', '2', '4', 'e', 'b', '3', 'b', 'd', '6', 'e', 'a', '4', '6', '7', '2', '6', '6']': should be a string (MD5 or SHA256), 2-tuple (type, value), or tuple of alternative checksum specs."

======================================================================
FAIL: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 996, in test_pr_sha256_checksums
    self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
AssertionError: False is not true : No checksum issues:
Non-SHA256 checksum(s) found for mdsplus-7.132.0_paths.patch: (['7', 'c', '4', '0', 'e', 'd', 'c', '8', '4', '7', '3', '7', 'd', 'd', 'b', '8', 'f', '7', '8', '5', 'b', 'd', 'c', '3', 'b', '8', '8', '6', '0', '4', 'a', '1', '6', 'e', 'c', 'd', '1', '6', 'f', '3', '8', 'b', '3', '1', '3', '0', '9', '8', '2', '4', 'e', 'b', '3', 'b', 'd', '6', 'e', 'a', '4', '6', '7', '2', '6', '6'],)

----------------------------------------------------------------------
Ran 18810 tests in 687.645s

FAILED (failures=1, errors=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

[akesandgren]

This unfortunately trips on easybuilders/easybuild-framework#4142 and the problems around that.
We'll probably need to wait until that is fixed.

[SimonPinches]

This PR now relies upon #19620.

[boegelbot]

@SimonPinches: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/7559878845
Output from first failing test suite run:

ERROR: test__parse_easyconfig_MDSplus-7.132.0-GCCcore-13.2.0.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for easyconfig MDSplus-7.132.0-GCCcore-13.2.0.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1631, in innertest
    template_easyconfig_test(self, spec_path)
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1488, in template_easyconfig_test
    res = verify_checksum(patch_full, checksum)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/filetools.py", line 1303, in verify_checksum
    checksum)
easybuild.tools.build_log.EasyBuildError: "Invalid checksum spec '['7', 'c', '4', '0', 'e', 'd', 'c', '8', '4', '7', '3', '7', 'd', 'd', 'b', '8', 'f', '7', '8', '5', 'b', 'd', 'c', '3', 'b', '8', '8', '6', '0', '4', 'a', '1', '6', 'e', 'c', 'd', '1', '6', 'f', '3', '8', 'b', '3', '1', '3', '0', '9', '8', '2', '4', 'e', 'b', '3', 'b', 'd', '6', 'e', 'a', '4', '6', '7', '2', '6', '6']': should be a string (MD5 or SHA256), 2-tuple (type, value), or tuple of alternative checksum specs."

======================================================================
ERROR: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 892, in test_dep_versions_per_toolchain_generation
    for ec in self.ordered_specs:
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 282, in ordered_specs
    EasyConfigTest.resolve_all_dependencies()
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 214, in resolve_all_dependencies
    cls._parsed_easyconfigs, modules_tool(), retain_all_deps=True)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/robot.py", line 463, in resolve_dependencies
    raise_error_missing_deps(totally_missing, extra_msg="no easyconfig file or existing module found")
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/robot.py", line 326, in raise_error_missing_deps
    raise EasyBuildError(error_msg)
easybuild.tools.build_log.EasyBuildError: 'Missing dependencies: Java/21 (no easyconfig file or existing module found)'

======================================================================
FAIL: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1020, in test_pr_sha256_checksums
    self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
AssertionError: False is not true : No checksum issues:
Non-SHA256 checksum(s) found for mdsplus-7.132.0_paths.patch: (['7', 'c', '4', '0', 'e', 'd', 'c', '8', '4', '7', '3', '7', 'd', 'd', 'b', '8', 'f', '7', '8', '5', 'b', 'd', 'c', '3', 'b', '8', '8', '6', '0', '4', 'a', '1', '6', 'e', 'c', 'd', '1', '6', 'f', '3', '8', 'b', '3', '1', '3', '0', '9', '8', '2', '4', 'e', 'b', '3', 'b', 'd', '6', 'e', 'a', '4', '6', '7', '2', '6', '6'],)

----------------------------------------------------------------------
Ran 18955 tests in 685.536s

FAILED (failures=1, errors=2)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

[Louwrensth]

@boegelbot Please test @ generoso

[github-actions]

Updated software MDSplus-7.132.0-GCCcore-13.2.0.eb

Diff against MDSplus-7.153.3-GCCcore-13.2.0.eb

easybuild/easyconfigs/m/MDSplus/MDSplus-7.153.3-GCCcore-13.2.0.eb

diff --git a/easybuild/easyconfigs/m/MDSplus/MDSplus-7.153.3-GCCcore-13.2.0.eb b/easybuild/easyconfigs/m/MDSplus/MDSplus-7.132.0-GCCcore-13.2.0.eb
index 1ec9435b84..8030c9f812 100644
--- a/easybuild/easyconfigs/m/MDSplus/MDSplus-7.153.3-GCCcore-13.2.0.eb
+++ b/easybuild/easyconfigs/m/MDSplus/MDSplus-7.132.0-GCCcore-13.2.0.eb
@@ -1,7 +1,7 @@
 easyblock = 'ConfigureMake'
 
 name = 'MDSplus'
-version = '7.153.3'
+version = '7.132.0'
 
 homepage = 'http://mdsplus.org/'
 description = """MDSplus is a set of software tools for data acquisition
@@ -11,18 +11,19 @@ toolchain = {'name': 'GCCcore', 'version': '13.2.0'}
 toolchainopts = {'pic': True}
 
 sources = [{
-    'filename': SOURCELOWER_TAR_XZ,
+    'filename': SOURCELOWER_TAR_GZ,
     'git_config': {
         'url': 'https://github.com/' + name,
         'repo_name': '%(namelower)s',
         'commit': 'stable_release-' + version.replace('.', '-'),
         'recursive': True,
-        # Explicitly do not keep the .git directory to avoid pulling submodules
-        # the git commands will fail during the bootstrap, but this is fine for the build
-        'keep_git_dir': False
     },
 }]
-checksums = ['21b864211513fd8aef80c4dfaa2a541fda21d73fa9edce26ef492a5e1dad6ee0']
+patches = ['%(namelower)s-%(version)s_paths.patch']
+checksums = [
+    {'mdsplus-7.132.0.tar.gz': 'aeed3f5de40de08eb371b55f531a9ffdff3be265d6a99cd415a928cd217350b3'},
+    {'mdsplus-7.132.0_paths.patch': 'd4bf4a840fc8e7126fb308ab8e9db974ce5e795953156cd6e0db63dc8c0f7fd6'},
+]
 
 builddependencies = [
     ('binutils', '2.40'),
@@ -30,9 +31,6 @@ builddependencies = [
     ('Bison', '3.8.2'),
     ('flex', '2.6.4'),
     ('gperf', '3.1'),
-    # Ensure we have git for the bootstrap that will run git commands to update submodules.
-    # We are fine with them failing as we do not have the .git directory, but avoid failing due to missing git
-    ('git', '2.42.0'),
 ]
 
 dependencies = [
@@ -47,7 +45,6 @@ preconfigopts = 'find . -type f -regex .*Makefile.* -maxdepth 12 -exec '
 preconfigopts += 'sed -i "s/JAVASOURCE = 6/JAVASOURCE = 8/g" {} + && '
 preconfigopts += 'export CFLAGS="$CFLAGS -I$EBROOTLIBXML2/include/libxml2 -std=c++14" && '
 preconfigopts += 'export FCFLAGS="$FCFLAGS -std=legacy -fallow-invalid-boz" && '
-preconfigopts += 'export MDSPLUS_DIR=$EBROOTMDSPLUS && '
 preconfigopts += 'cd %(builddir)s/mdsplus && ./bootstrap && '
 
 configopts = '--with-jdk=$JAVA_HOME --enable-java '

[akesandgren]

We already have 7.153.3 for GCCcore/13.2.0 merged so closing this one.