Fix rename tech debt, restructure internal docs#10
Merged
Conversation
…ols, XDG cache - Fix parse_wheel_filename to count python/abi/platform from end instead of fragile isdigit() heuristic for build tag detection - Fix rename_wheel_from_bytes to raise ValueError on malformed dist-info instead of silently falling back to version "0.0.0" - Extract _rename_wheel_files() shared helper, eliminating ~100 lines of duplication between rename_wheel and rename_wheel_from_bytes - Fix inspect_wheel to use proper booleans instead of string "True"/"False" - Fix cache_dir() to respect XDG_CACHE_HOME - Fix CLI inspect bool check from == "True" to truthiness - Add comprehensive tests: TestParseWheelFilenameEdgeCases, TestRenameWheelFromBytes, TestInspectWheel, TestCacheDir, TestRenameCacheKey, plus update_imports=False and .tar.gz rejection - Update AGENTS.md known issues checklist (12 items now resolved) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move detailed internal documentation from AGENTS.md into topic-focused files under INTERNAL_DOCS/ (architecture, testing, known-issues, etc.). AGENTS.md now links to CLAUDE.md for rules and provides agent-specific guidance. CLAUDE.md is the single source of truth for project rules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add INTERNAL_DOCS/planning.md with current priorities, decisions log, session notes, and conventions for cross-session communication - Add purpose descriptions to all INTERNAL_DOCS/ files - Cross-reference planning.md from known-issues.md - Update AGENTS.md and CLAUDE.md to reference planning.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ianhi
added a commit
that referenced
this pull request
Mar 11, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ianhi
added a commit
that referenced
this pull request
Mar 11, 2026
…ng (#11) * Update planning.md session notes after v0.2.0 release and PR #10 merge Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix critical XSS, UnicodeDecodeError, broad exceptions, and fragile stream rewriting - Fix XSS in server/html.py: escape all user-controlled values with html.escape() - Fix UnicodeDecodeError in rename.py and patch.py: gracefully skip non-UTF8 .py files - Fix broad except Exception in run.py (now TOMLDecodeError/ValueError/KeyError) and upstream.py (now ValueError/TypeError) - Log upstream HTTP errors instead of silently swallowing them - Fix fragile filename rewriting in stream.py: use parse_wheel_filename() instead of naive split("-") - Fix type annotations in _find_package_dir: explicit set[str] and dict[str, int] - Update known-issues.md and planning.md with round 2 review findings Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_wheel_filenameto count python/abi/platform tags from end instead of fragileisdigit()heuristicrename_wheel_from_bytesto raiseValueErroron malformed dist-info instead of silent fallback to version"0.0.0"_rename_wheel_files()shared helper eliminating ~100 lines of duplication betweenrename_wheelandrename_wheel_from_bytesinspect_wheelto use proper booleans instead of string"True"/"False"cache_dir()to respect$XDG_CACHE_HOMErename_wheel_from_bytes,inspect_wheel,cache_dir,rename_cache_key,parse_wheel_filenameedge cases, andupdate_imports=FalseINTERNAL_DOCS/directory with topic-focused files. Addplanning.mdfor cross-session agent communication.Test plan
uv run pytest tests/)🤖 Generated with Claude Code