Closed
Conversation
…tput to diagnose issues
…s should run without recording when 'mvn verify' is run. On CI Cypress should run with recording. Options can be overriden locally on in CI with 'mvn -P'.
… should go in target/
Member
Contributor
Author
|
@line-o #306 doesn't fix the issue of flaky test as I tried to explain in the last Community Call. Also I would suggest that #306 has more than one focus as it sounds. #306 should only fix the WebSocket issue and add a Test for the WebSocket issue, but there is a lot more in there that should not be. The test suite should be fixed (i.e. this PR is a start for that) before #298 or #306 gets merged. |
Merged
Member
|
superseded by #317 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be the absolute minimum needed to fix the Tests and have them Green light in CI.
NOTE: At this time, this shows that we still have flaky Cypress tests. Sometimes the Console test passes and sometimes it doesn't. I am pretty sure these are not caused by Cypress, but rather by eXist-db missing a patch that we have in Elemental. I will patch eXist-db locally and see if it fixes the flakyiness of the test.