Skip to content

fix(video): scope shaka-play-button reset to shaka-play-button-container#600

Merged
HenriqueLimas merged 1 commit intomainfrom
fix-video-compat
Apr 3, 2026
Merged

fix(video): scope shaka-play-button reset to shaka-play-button-container#600
HenriqueLimas merged 1 commit intomainfrom
fix-video-compat

Conversation

@HenriqueLimas
Copy link
Copy Markdown
Member

@HenriqueLimas HenriqueLimas commented Apr 2, 2026

  • Fixes #

Description

Prevents the button style reset from affecting compact control panel buttons.

Notes

Screenshots

Screenshot 2026-04-02 at 10 08 08 AM

Checklist

  • I verify all changes are within scope of the linked issue
  • I added/updated/removed testing (Storybook in Skin) coverage as appropriate
  • I tested the UI in all supported browsers
  • I tested the UI in dark mode and RTL mode

Prevents the button style reset from affecting compact control panel buttons.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@HenriqueLimas HenriqueLimas self-assigned this Apr 2, 2026
Copilot AI review requested due to automatic review settings April 2, 2026 17:08
@HenriqueLimas HenriqueLimas added the P3 Needs to be fixed relatively soon, but no rush label Apr 2, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2026

🦋 Changeset detected

Latest commit: d2b2c00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Scopes the Shaka play button style reset so it doesn’t unintentionally affect buttons in the compact control panel, keeping video player controls visually consistent.

Changes:

  • Updated the play button reset selector to target .shaka-play-button only when inside .shaka-play-button-container.
  • Regenerated the corresponding dist CSS output.
  • Added a patch changeset for @ebay/skin.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/skin/src/sass/video/video.scss Narrows the CSS reset selector for the Shaka play button to the play button container.
packages/skin/dist/video/video.css Updated built CSS to reflect the Sass selector change.
.changeset/ready-mirrors-like.md Declares a patch release with a short note describing the fix.

"@ebay/skin": patch
---

fix(video): apply button cleanup to play-button-container only
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description still has the required issue reference placeholder (Fixes #) left blank. Please link the actual issue number (e.g., Fixes #1234) so the change is properly tracked and auto-closed on merge.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HenriqueLimas HenriqueLimas merged commit 5c868e1 into main Apr 3, 2026
9 checks passed
@HenriqueLimas HenriqueLimas deleted the fix-video-compat branch April 3, 2026 18:32
@github-actions github-actions bot mentioned this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Needs to be fixed relatively soon, but no rush package: skin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants