Skip to content

feat: evo-dialog component#596

Open
LuLaValva wants to merge 5 commits intomainfrom
evo-dialog
Open

feat: evo-dialog component#596
LuLaValva wants to merge 5 commits intomainfrom
evo-dialog

Conversation

@LuLaValva
Copy link
Copy Markdown
Member

Things to look at

  • Moved from bannerImgSrc and bannerImgPosition to <@banner src="..." position="...">
    • Attr tag allows body, so custom content may also be added as well (<@banner><rive-asset/></>)
  • Default to closedby="any", users may override

Copilot AI review requested due to automatic review settings April 1, 2026 18:33
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 1, 2026

🦋 Changeset detected

Latest commit: aefe198

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@evo-web/marko Patch
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the Marko 6 evo-dialog tag to evo-marko, aligning with Skin’s native <dialog> styling/behavior from issue #435, and updates Skin dialog styling to support an expressive dialog layout with an optional “previous” button.

Changes:

  • Introduces packages/evo-marko/src/tags/evo-dialog (component, stories, examples, tests, Skin style import).
  • Updates Skin dialog header spacing and adds expressive layout rules for prev/close overlap.
  • Adds a docs-page example for “Expressive Dialog with Previous Button”.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/routes/_index/components/dialog/css+page.marko Adds docs/demo markup for expressive dialog with a previous button.
packages/skin/src/sass/dialog/dialog.scss Updates dialog header spacing + adds expressive prev/close layout rules.
packages/skin/dist/dialog/dialog.css Regenerated dist CSS for dialog changes.
packages/evo-marko/src/tags/evo-dialog/index.marko Implements the evo-dialog Marko tag API and markup using native <dialog>.
packages/evo-marko/src/tags/evo-dialog/style.ts Pulls in @ebay/skin/dialog styles for the tag.
packages/evo-marko/src/tags/evo-dialog/README.md Adds component docs + Storybook links.
packages/evo-marko/src/tags/evo-dialog/dialog.stories.ts Adds Storybook stories and argTypes for the new tag.
packages/evo-marko/src/tags/evo-dialog/examples/default.marko Adds a default usage example.
packages/evo-marko/src/tags/evo-dialog/examples/banner.marko Adds a banner image usage example via <@banner src position/>.
packages/evo-marko/src/tags/evo-dialog/examples/custom-banner.marko Adds a custom banner-body usage example via <@banner>...</@banner>.
packages/evo-marko/src/tags/evo-dialog/test/test.server.ts Adds server-side snapshot coverage for key prop variants.
packages/evo-marko/src/tags/evo-dialog/test/test.browser.ts Adds browser tests for structure, a11y linkage, and size variants.

LuLaValva and others added 3 commits April 1, 2026 12:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants