Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

fix(carousel): ensure controlled index always updates scroll position#2465

Merged
agliga merged 2 commits into15.2.0from
2463-carousel-bug
Mar 27, 2025
Merged

fix(carousel): ensure controlled index always updates scroll position#2465
agliga merged 2 commits into15.2.0from
2463-carousel-bug

Conversation

@LuLaValva
Copy link
Copy Markdown
Member

Description

  • Carousel was breaking under certain circumstances related to controlled index
  • In previous versions, receiving index from input stops effecting scroll after it has been changed rapidly multiple times in a row, or after the user manually uses the scrollbar to update index
  • I added a story to carousel where controlled carousel can be tested

@LuLaValva LuLaValva requested a review from agliga March 25, 2025 13:19
@LuLaValva LuLaValva self-assigned this Mar 25, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: f616e0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga merged commit 46423cb into 15.2.0 Mar 27, 2025
5 checks passed
@agliga agliga deleted the 2463-carousel-bug branch March 27, 2025 17:01
This was referenced Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants