fix: add config_changing_ guard to set_priority()#651
Open
Qian-Cheng-nju wants to merge 2 commits intoeBay:masterfrom
Open
fix: add config_changing_ guard to set_priority()#651Qian-Cheng-nju wants to merge 2 commits intoeBay:masterfrom
Qian-Cheng-nju wants to merge 2 commits intoeBay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for NuRaft!
I noticed a small gap in the config change guard and put together a fix.
set_priority() appends a ConfigEntry without checking config_changing_, so if called right after a leader election (before the BecomeLeader ConfigEntry is committed), it creates two uncommitted config entries in the log. This breaks the one-config-change-at-a-time invariant that handle_add_srv_req and handle_rm_srv_req both enforce.
The fix adds the same config_changing_ check that the other config-modifying paths already have.