Homeobject side graceful shutdown#254
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 63.15% 61.24% -1.92%
==========================================
Files 32 33 +1
Lines 1900 2722 +822
Branches 204 330 +126
==========================================
+ Hits 1200 1667 +467
- Misses 600 880 +280
- Partials 100 175 +75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| start_shutting_down(); | ||
| // Wait for all pending requests to complete | ||
| while (true) { | ||
| auto pending_reqs = get_pending_request_num(); |
There was a problem hiding this comment.
baseline resync be considered as HS or HO?
There was a problem hiding this comment.
it will be considered as HS.
Homeobject side graceful shutdown will only make sure that when shutting down homeobject , there is no pending external (or user api) calls from upper layer and reject later api calls .
baseline resync is a mechanism of statemachin(raft), and all the baseline resync related code in homeobject is called by statemachine. homeobject can not do anything for this. so , we need to handle this in raft level (homestore).
i will try to submit another pr for homestore graceful shutdown.
ab6ba94 to
023a31c
Compare
ec3e0bf to
8f6e0ab
Compare
this PR add counters to record the pending request and start shutdown homestore when no pending request
8f6e0ab to
b67dbca
Compare
this PR add counters to record the pending request and start shutdown homestore when no pending request