Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an
EnumclassSimModeto replace raw string representations of simulation modes, providing better type safety and developer experience. Additionally, it identifies and implements a newPhysDomainconcept to distinguish between simulation modes and physical domains.Key Changes
SimModeEnum:PhysDomainEnum:modeparameters tosim_modefor claritypipeflow(net, mode="hydraulics")Why Enums?
Pending Items (Future PRs)
Feedback Requested
Naming Concerns
I'm uncertain if these names are optimal. Please suggest alternatives:
SimMode→CalcMode?PhysDomain→ResultMode?PhysDomainconcept actually needed?The renaming is trivial, so please don't feel burdened by suggesting your preferences!
Import Concert
Currently enums are imported as:
But would this be more user-friendly?