Skip to content

feat: Added Translator#147

Open
AsmitaMishra24 wants to merge 2 commits intodvjsharma:masterfrom
AsmitaMishra24:master
Open

feat: Added Translator#147
AsmitaMishra24 wants to merge 2 commits intodvjsharma:masterfrom
AsmitaMishra24:master

Conversation

@AsmitaMishra24
Copy link
Copy Markdown
Contributor

Description

Added Translator.

Issue No.:

Fixes #111

Changes

  1. Added Translator to the navbar.
  2. Adjusted Navbar layout and spacing.
  3. Styled Dropdown Menu for the Translator button.

Screenshot:-

Recording.2024-07-20.021050.1.1.mp4

@AsmitaMishra24 AsmitaMishra24 changed the title Added Translator Feat: Added Translator Jul 19, 2024
@AsmitaMishra24 AsmitaMishra24 changed the title Feat: Added Translator feat: Added Translator Jul 19, 2024
@dvjsharma
Copy link
Copy Markdown
Owner

Hi @AsmitaMishra24, few points:

  1. Functionality looks good.
  2. The position of button is quite redundant, and it also displaces the central logo. This might also break in responsive design. Please look for better placements/design.
  3. (Not a hard requirement since this component might never change) We use tailwind CSS in the entire project, I see you have used plain CSS. Please migrate to tailwind CSS.

@AsmitaMishra24
Copy link
Copy Markdown
Contributor Author

Hi @AsmitaMishra24, few points:

  1. Functionality looks good.
  2. The position of button is quite redundant, and it also displaces the central logo. This might also break in responsive design. Please look for better placements/design.
  3. (Not a hard requirement since this component might never change) We use tailwind CSS in the entire project, I see you have used plain CSS. Please migrate to tailwind CSS.

@dvjsharma, ok....I will make the changes and inform you accordingly

Copy link
Copy Markdown
Owner

@dvjsharma dvjsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates? I also see conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Google Translator Integration

2 participants