Add an integration test for empty-config handling#3395
Merged
kzar merged 1 commit intoduckduckgo:mainfrom Feb 17, 2026
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
We want to make sure that if an empty (but valid) remote configuration or blocklist are loaded, the extension handles that OK and doesn't break. Let's add a test that covers that situation now.
kzar
force-pushed
the
min-config-test
branch
from
29a2de4 to
62a6fb9
Compare
dharb
approved these changes
Feb 16, 2026
Contributor
dharb
left a comment
dharb
left a comment
There was a problem hiding this comment.
Changes look solid to me, some nice simplifications in there. Not sure what's going on with the pixel schema validation check, mind following up on that before we merge?
Collaborator
Author
@dharb Thanks! Don't worry, that failure is just because the branch is on my fork, some of the CI jobs like that won't run from forks unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to make sure that if an empty (but valid) remote configuration or
blocklist are loaded, the extension handles that OK and doesn't break. Let's add
a test that covers that situation now.