Add TIME_NS support #515
Merged
Add TIME_NS support #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for fetching `TIME_NS` values as instances of `java.time.LocalTime` class, example: ```java LocalTime lt = rs.getObject(1, LocalTime.class); ``` Nanosecond precision is maintained on fetching `TIME_NS` values from DB. Currently it is not possible to preserve nanosecond precision when inserting `TIME_NS` values using query parameters. The support is necessary to fix `test_all_types` failures introduced by duckdb/duckdb#20361.
Collaborator
Author
|
Merging to allow vendoring PR #513 to pass tests and be integrated, bringing in updated engine with duckdb/duckdb#20361 included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fetching
TIME_NSvalues as instances ofjava.time.LocalTimeclass, example:Nanosecond precision is maintained on fetching
TIME_NSvalues from DB.Currently it is not possible to preserve nanosecond precision when inserting
TIME_NSvalues using query parameters.The support is necessary to fix
test_all_typesfailures introduced by duckdb/duckdb#20361.