Daemonize query cancel scheduler thread #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of `Statement#setQueryTimeout()` added in duckdb#247 uses a background thread to perform the query cancellation on timeout. Because that thread is not marked as "daemon" one, it can prevent JVM shutdown. This change makes the scheduler thread "daemon" and additionally exposes `DuckDBDriver#shutdownQueryCancelScheduler()` method that allows to shut down the scheduler manually. Testing: manual test added that checks that queries with timeout set can be executed (with timeout ineffective) after the scheduler is shut down. Fixes: duckdb#504
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Jan 8, 2026
This is a backport of the PR duckdb#505 to `v1.4-andium` stable branch. The implementation of `Statement#setQueryTimeout()` added in duckdb#247 uses a background thread to perform the query cancellation on timeout. Because that thread is not marked as "daemon" one, it can prevent JVM shutdown. This change makes the scheduler thread "daemon" and additionally exposes `DuckDBDriver#shutdownQueryCancelScheduler()` method that allows to shut down the scheduler manually. Testing: manual test added that checks that queries with timeout set can be executed (with timeout ineffective) after the scheduler is shut down. Fixes: duckdb#504
staticlibs
added a commit
that referenced
this pull request
Jan 9, 2026
This is a backport of the PR #505 to `v1.4-andium` stable branch. The implementation of `Statement#setQueryTimeout()` added in #247 uses a background thread to perform the query cancellation on timeout. Because that thread is not marked as "daemon" one, it can prevent JVM shutdown. This change makes the scheduler thread "daemon" and additionally exposes `DuckDBDriver#shutdownQueryCancelScheduler()` method that allows to shut down the scheduler manually. Testing: manual test added that checks that queries with timeout set can be executed (with timeout ineffective) after the scheduler is shut down. Fixes: #504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
Statement#setQueryTimeout()added in #247 uses a background thread to perform the query cancellation on timeout. Because that thread is not marked as "daemon" one, it can prevent JVM shutdown.This change makes the scheduler thread "daemon" and additionally exposes
DuckDBDriver#shutdownQueryCancelScheduler()method that allows to shut down the scheduler manually.Testing: manual test added that checks that queries with timeout set can be executed (with timeout ineffective) after the scheduler is shut down.
Fixes: #504