This repository was archived by the owner on Sep 9, 2022. It is now read-only.
Resolve duplicate naming issue by including instance-ID#450
Open
Vermyndax wants to merge 2 commits intodtan4:masterfrom
Vermyndax:master
Open
Resolve duplicate naming issue by including instance-ID#450Vermyndax wants to merge 2 commits intodtan4:masterfrom Vermyndax:master
Vermyndax wants to merge 2 commits intodtan4:masterfrom
Vermyndax:master
Conversation
added 2 commits
March 19, 2019 12:38
…es. new format: <instance_id>_<instance_name>
dtan4
suggested changes
Apr 21, 2019
Owner
dtan4
left a comment
dtan4
left a comment
There was a problem hiding this comment.
Sorry for the late reply 🙇
The change of template looks good, but please do the following to merge it.
- Please follow the current master branch
- Please remove
version.rbchange- This will be done independently like #456
- Please update existing unit tests to use the new naming rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #417 by prefixing the aws_instance resource names with the instance ID. This was a problem for us in that most of our EC2 instances are produced from autoscaling groups and have duplicate name tags.