refactor: convert log calls to parameterized logging in DDK builder/generator/UI#1307
Draft
joaodinissf wants to merge 4 commits intodsldevkit:masterfrom
Draft
refactor: convert log calls to parameterized logging in DDK builder/generator/UI#1307joaodinissf wants to merge 4 commits intodsldevkit:masterfrom
joaodinissf wants to merge 4 commits intodsldevkit:masterfrom
Conversation
2 tasks
Replace string concatenation, NLS.bind, and MessageFormat.format in
log calls with parameterized {} placeholders. Use Supplier/method-refs
for lazy argument evaluation where appropriate.
Modules: check.core.test, check.runtime.core, check.runtime.ui,
check.ui, checkcfg.core
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace string concatenation with parameterized {} placeholders.
Use Supplier lambdas for lazy argument evaluation. Add NOPMD
suppressions for SLF4J logger calls (SwtBot uses SLF4J, not Log4j).
Add org.apache.logging.log4j.util to OSGi manifests for Supplier.
Modules: test.core, test.ui
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace string concatenation, NLS.bind, and MessageFormat.format in
log calls with parameterized {} placeholders. Use Supplier/method-refs
for lazy argument evaluation. Extract duplicate format strings to
constants. Add org.apache.logging.log4j.util to OSGi manifest.
Modules: xtext, typesystem
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…enerator/UI
Replace string concatenation and NLS.bind in log calls with
parameterized {} placeholders. Use Supplier/method-refs for lazy
argument evaluation. Add NOPMD suppressions for ITraceSet.trace()
and Supplier method-refs not recognized by PMD. Add
org.apache.logging.log4j.util to OSGi manifests.
Modules: xtext.builder, xtext.expression, xtext.generator,
xtext.ui, xtext.test.core
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/pmd-guard-log/ddk-builder-gen-ui
branch
from
0cfcee8 to
43d0eaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1306
Summary
Replace string concatenation and
NLS.bindin log calls with parameterized{}placeholders. UseSupplier/method-refs for lazy argument evaluation. Add NOPMD suppressions forITraceSet.trace()andSuppliermethod-refs not recognized by PMD. Addorg.apache.logging.log4j.utilto OSGi manifests.Modules:
xtext.builder,xtext.expression,xtext.generator,xtext.ui,xtext.test.core🤖 Generated with Claude Code