driver: cleanup of the Common and MAVCAN Drivers#92
Open
joshanne wants to merge 1 commit intodronecan:masterfrom
Open
driver: cleanup of the Common and MAVCAN Drivers#92joshanne wants to merge 1 commit intodronecan:masterfrom
joshanne wants to merge 1 commit intodronecan:masterfrom
Conversation
Removes duplicate methods. Corrects comments on methods. Marks statically used methods as such.
tpwrules
reviewed
Jan 12, 2026
| pass | ||
|
|
||
| def get_filter_list(self, ids): | ||
| '''get list of message IDs to accept, None means accept all''' |
Collaborator
There was a problem hiding this comment.
Why did the parameters change?
Collaborator
Author
There was a problem hiding this comment.
I believe this looks to be a copy/paste error.
The get_filter_list function exists below with no additional parameters.
As far as I can tell, no other callers are making use of the get_filter_list while specifying additional parameters.
The only thing that should possibly be changed is to update the function comment to:
'''get list of message IDs to accept, None means accept all'''
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes duplicate methods. Corrects comments on methods. Marks statically used methods as such.