fix: serialize non-finite accessibility ranges - #150
Merged
Conversation
Contributor
🧪 Test Build ReadyAPK for PR #150 is available for testing. Download APK from workflow run Artifacts expire after 30 days. |
RasulOs
marked this pull request as ready for review
July 23, 2026 18:42
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
null.min,max, andcurrentvalues and the rangetype.-Infinity,+Infinity,NaN, and finite ranges.Root cause
Android permits accessibility ranges with infinite bounds. Portal copied those values directly into its accessibility-tree JSON, but JSON encoding rejects non-finite numbers with
Forbidden numeric value: -Infinity. As a result,state_full/get_statefailed and the client repeatedly retried an unrecoverable serialization error.User impact
Accessibility trees containing unbounded ranges now return valid JSON. Consumers receive
nullfor non-finite range fields instead of losing the entire device state response.Validation
AccessibilityTreeBuilderTest: 7/7 passedstate_fullvalidation: successful valid JSON with no forbidden numeric-value errorSwitchTintResourceTest.trackTintSeparatesCheckedAndUncheckedStatescolor mismatch (#0D9373expected,#4566D9actual); the relevant resources and test are unchanged fromorigin/mainReferences droidrun/mobilerun#386.