Added new config option rails_webpacker_use_webpacker4#82
Added new config option rails_webpacker_use_webpacker4#82zealot128 wants to merge 1 commit intodresden-weekly:developfrom
Conversation
|
The reasoning seems legit. I'm also not a fan of multiple bool variables. I suggest to simply use |
7e130f4 to
b18fd0e
Compare
|
Great suggestion, fixed it! |
arBmind
left a comment
There was a problem hiding this comment.
Thank you! Seems legit.
Once TravisCI works again, this should be merged.
|
Yeah... that rvm public key has changed .... Had this problem also for newer Ruby versions. Something like this fixed it for a new system: Unfortunately, if the script already imported the old pubkey, than gpg --list-keys returns 0 = success, even when called with two keys. Do you or any other people working on fixing CI? |
Webpacker 4 changed default config files babelrc and postcssrc: rails/webpacker@8d496a0
Webpacker 4 changed default config files babelrc and postcssrc:
rails/webpacker@8d496a0
Thus, the default export is different in this case....
not totally fan of the conditional :/
/cc @hendrixfan