Fix typo: keep private field as UInt16 in CLS compliance #50799
Merged
BillWagner merged 2 commits intodotnet:mainfrom Jan 7, 2026
Merged
Fix typo: keep private field as UInt16 in CLS compliance #50799BillWagner merged 2 commits intodotnet:mainfrom
BillWagner merged 2 commits intodotnet:mainfrom
Conversation
BillWagner
approved these changes
Jan 5, 2026
Member
BillWagner
left a comment
There was a problem hiding this comment.
Thanks @yasaminashoori
Once I make one small change so the sample compiles, this is ready to ![]()
samples/snippets/csharp/VS_Snippets_CLR/conceptual.clscompliant/cs/public2.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@BillWagner Thanks for the quick review and the fix 🌹Really appreciate it. Looking forward to contributing more! Update: |
auto-merge was automatically disabled
January 5, 2026 23:06
Pull request was closed
gewarren
pushed a commit
to gewarren/docs
that referenced
this pull request
Jan 8, 2026
* fix typo: keep private field as UInt16 in CLS compliance example Fixe dotnet#49691 * Update samples/snippets/csharp/VS_Snippets_CLR/conceptual.clscompliant/cs/public2.cs --------- Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 🌹 thanks for your great works.
Summary
Fixed the code in the CLS compliance documentation where the private field was incorrectly changed to
Int16.The documentation states:
However, the code example in
public2.csshowed both the private and public members changed toInt16, which contradicts the documentation.Fix
Changed
private Int16 personAgeback toprivate UInt16 personAge.Fixes issue: #49691