Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for redirecting console logger output to standard error (stderr) stream, providing more flexibility for log output configuration. The PR also improves code documentation and modernizes parameter types.
- Introduces
LoggerConsoleOutputToenum to control whether logs write to stdout or stderr - Adds
WithOutput()method toConsoleLoggerBuilderfor configuring output destination - Improves parameter types by changing from
string[]toIReadOnlyList<string>for better API design
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DotNetCampus.Logger/Writers/ConsoleLogger.cs | Implements stderr support by adding OutputTo property and modifying output stream selection logic; converts SafeWriteLine from static to instance method; adds lazy initialization for output writer |
| src/DotNetCampus.Logger/Writers/ConsoleLoggerBuilder.cs | Adds WithOutput() method for configuring console output destination; refactors internal state management to support new OutputTo feature; improves documentation comments |
| src/DotNetCampus.Logger/Writers/Helpers/TagFilterManager.cs | Updates method signatures to use IReadOnlyList<string> instead of string[] for better API design |
| src/DotNetCampus.Logger/LoggerBuilder.cs | Adds comprehensive XML documentation comments for all public methods |
| src/DotNetCampus.Logger/DotNetCampus.Logger.csproj | Removes debug-mode suppression of documentation warnings (CS1591) to enforce documentation completeness |
| src/DotNetCampus.Logger/Writers/TraceLogger.g.cs | Adds <inheritdoc /> documentation comment to IsEnabled method |
| src/DotNetCampus.Logger/Writers/DebugLogger.g.cs | Adds <inheritdoc /> documentation comment to IsEnabled method |
| src/DotNetCampus.Logger/CompositeLogger.cs | Adds <inheritdoc /> documentation comments to IsEnabled and Log methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lindexi
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.