fix: dynamically select timeout method to avoid PicklingError on macOS (#185)#186
Merged
seanthegeek merged 2 commits intodomainaware:masterfrom Oct 1, 2025
Merged
fix: dynamically select timeout method to avoid PicklingError on macOS (#185)#186seanthegeek merged 2 commits intodomainaware:masterfrom
seanthegeek merged 2 commits intodomainaware:masterfrom
Conversation
|
@sbarbett THX for your fix! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a platform-specific issue on macOS where
check_domains()fails with aPicklingErrordue to Python’smultiprocessingdefaulting to thespawnstart method. The decoratedtest_starttlsfunction cannot be pickled, which causes the subprocess to fail.See issue #185 for the problem report and stack trace.
Changes:
Introduces a private helper function
_get_timeout_method()that:Applies this selection dynamically to
timeout_decorator.timeout(..., use_signals=...)intest_starttls.Rationale:
Using signal-based timeouts on macOS avoids the need to pickle the decorated function, preventing
PicklingError. This approach is cross-platform, does not change behavior for Linux, and gracefully handles multithreaded environments.Testing:
Verified on:
check_domains()now runs without raisingPicklingError.Related Issue
Closes #185.