Android: Fix windowed to fullscreen crash using vulkan renderer.#14483
Open
Linkinworm wants to merge 1 commit intodolphin-emu:masterfrom
Open
Android: Fix windowed to fullscreen crash using vulkan renderer.#14483Linkinworm wants to merge 1 commit intodolphin-emu:masterfrom
Linkinworm wants to merge 1 commit intodolphin-emu:masterfrom
Conversation
…d full screen modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix an issue where using vulkan on android and swapping to windowed mode and back to full screen would crash the emulator.
I have tried to debug to check it returns back to desired KHR modes and it seems to, but if someone could verify first? It possibly might just be using the FIFO_KHR modes though regardless but my logs showed it was returning back to MAILBOX.
The other work around currently is to force V_sync which is how I determined that using FIFO mode during surface changes should fix it.