Добавляет "На практике" в Promise.try()#5988
Open
zheleznikov wants to merge 8 commits into
Open
Conversation
zheleznikov
requested review from
HellSquirrel,
Inventoris,
ra1nbow1 and
vitya-ne
as code owners
vitya-ne
reviewed
Apr 20, 2026
vitya-ne
reviewed
Apr 20, 2026
Contributor
|
Привет, спасибо за дополнение. Посмотри, пожалуйста, пару коментов |
Contributor
Author
|
@vitya-ne |
vitya-ne
reviewed
Apr 22, 2026
Превью контента из 5ee0c7d опубликовано. |
ra1nbow1
reviewed
May 11, 2026
|
|
||
| Во всех случаях результат попадёт в `then()`, а ошибка — в `catch()`. | ||
|
|
||
| `Promise.try()` возвращает промис, поэтому результат `onSubmit` можно обрабатывать одинаково, независимо от того, синхронная это функция или асинхронная. |
Member
There was a problem hiding this comment.
По-моему эта мысль уже сказана в предыдущем предложении
Comment on lines
+11
to
+21
| ```js | ||
| function handleSubmit(onSubmit) { | ||
| Promise.try(onSubmit) | ||
| .then((result) => { | ||
| console.log('Успех:', result) | ||
| }) | ||
| .catch((error) => { | ||
| console.error('Ошибка:', error.message) | ||
| }) | ||
| } | ||
| ``` |
Member
There was a problem hiding this comment.
Давай прокинем в аргументы formData? Реальный обработчик формы почти всегда принимает данные формы. Было бы полезно показать вариант с передачей данных. Это и полнее раскрывает API, и ближе к реальному использованию
Ну и return я бы дописал
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Добавлен пример "На практике" по
Promise.try().Превью: https://content-5988.dev.doka.guide/js/promise-try/#na-praktike
Текст оформлен согласно руководству по стилю