Merged
Conversation
joe0BAB
commented
Jun 20, 2025
pkg/stub/ipc.go
Outdated
| close() | ||
| } | ||
|
|
||
| func NewIPC(sockConn net.Conn, handler http.Handler) (result Ipc, retErr error) { |
Collaborator
Author
There was a problem hiding this comment.
This export is just temporary to make the linter happy. Will remove once it's used in follow up PR / on the stub.
Benehiko
reviewed
Jun 20, 2025
Member
Benehiko
left a comment
Benehiko
left a comment
There was a problem hiding this comment.
Yeah this code is hard to read, it's doing a lot of things which aren't too obvious.
I'll have to think a bit more about how we can separate the implementation details
joe0BAB
force-pushed
the
feat/stub-ipc
branch
2 times, most recently
from
317338f to
c89f8e7
Compare
joe0BAB
force-pushed
the
feat/stub-ipc
branch
4 times, most recently
from
4c16bca to
dbcbf2b
Compare
Benehiko
reviewed
Jun 23, 2025
Member
Benehiko
left a comment
Benehiko
left a comment
There was a problem hiding this comment.
Looks a lot better!
Just a small nit
Benehiko
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.