Skip to content

chore(go): 1.26#723

Merged
doringeman merged 5 commits intodocker:mainfrom
doringeman:bump-go
Mar 3, 2026
Merged

chore(go): 1.26#723
doringeman merged 5 commits intodocker:mainfrom
doringeman:bump-go

Conversation

@doringeman
Copy link
Contributor

$ ./scripts/sync-go-version.sh sync
Go version from go.mod: 1.26.0

Syncing Go version to 1.26.0...

Updated: ./Makefile
  GO_VERSION := 1.25.6 -> GO_VERSION := 1.26.0
Updated: ./cmd/cli/Dockerfile
  ARG GO_VERSION=1.25 -> ARG GO_VERSION=1.26
Updated: ./Dockerfile
  ARG GO_VERSION=1.25 -> ARG GO_VERSION=1.26
Updated: .github/workflows/release.yml
            go-version: 1.25.6 -> go-version: 1.26.0
Updated: .github/workflows/integration-test.yml
            go-version: 1.25.6 -> go-version: 1.26.0
Updated: .github/workflows/ci.yml
            go-version: 1.25.6 -> go-version: 1.26.0

Done. Review changes with: git diff

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version from 1.25 to 1.26 across various files, including go.mod, Makefile, and Dockerfiles. The changes appear to be automated by a script and are consistent. However, this version bump introduces a critical issue: the Docker builds will fail as they now depend on official Go 1.26 base images which are not yet available on Docker Hub. This needs to be resolved before this pull request can be merged.

# syntax=docker/dockerfile:1

ARG GO_VERSION=1.25
ARG GO_VERSION=1.26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to Go 1.26 will cause the Docker build to fail because the base image docker.io/library/golang:1.26-bookworm (used on line 14) does not exist on Docker Hub yet. For the build to succeed, either this change needs to be deferred until the official image is released, or the build process must be updated to use a custom-built Go 1.26 image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# syntax=docker/dockerfile:1

ARG GO_VERSION=1.25
ARG GO_VERSION=1.26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to the root Dockerfile, updating the Go version to 1.26 here will break the build. The base image golang:1.26-alpine3.23 (used on line 8) is not yet available on Docker Hub. This will cause a build failure unless a custom image is provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean if you can make the build go green and are confident nothing breaks

…G705)

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
@doringeman doringeman merged commit 59280ed into docker:main Mar 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants