Conversation
doringeman
commented
Mar 2, 2026
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
There was a problem hiding this comment.
Code Review
This pull request updates the Go version from 1.25 to 1.26 across various files, including go.mod, Makefile, and Dockerfiles. The changes appear to be automated by a script and are consistent. However, this version bump introduces a critical issue: the Docker builds will fail as they now depend on official Go 1.26 base images which are not yet available on Docker Hub. This needs to be resolved before this pull request can be merged.
| # syntax=docker/dockerfile:1 | ||
|
|
||
| ARG GO_VERSION=1.25 | ||
| ARG GO_VERSION=1.26 |
There was a problem hiding this comment.
This update to Go 1.26 will cause the Docker build to fail because the base image docker.io/library/golang:1.26-bookworm (used on line 14) does not exist on Docker Hub yet. For the build to succeed, either this change needs to be deferred until the official image is released, or the build process must be updated to use a custom-built Go 1.26 image.
There was a problem hiding this comment.
| # syntax=docker/dockerfile:1 | ||
|
|
||
| ARG GO_VERSION=1.25 | ||
| ARG GO_VERSION=1.26 |
There was a problem hiding this comment.
ericcurtin
left a comment
There was a problem hiding this comment.
I mean if you can make the build go green and are confident nothing breaks
…G705) Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>