Add retries even for models without fallbacks#1886
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 3, 2026
Merged
Conversation
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
krissetto
approved these changes
Mar 2, 2026
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ LGTM - This PR successfully adds retry support for models without fallbacks and handles transient Anthropic 529 errors.
The changes are well-implemented with:
- Proper HTTP 529 status code handling for Anthropic overloaded errors
- New retryable error patterns for network/connection issues
- Updated behavior to provide default retries even without fallback models
- Comprehensive test coverage for the new functionality
The logic changes are intentional and well-documented. The new retry behavior provides better resilience against transient errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.