Reduce builtin tool prompt lengths while preserving key examples#1879
Reduce builtin tool prompt lengths while preserving key examples#1879dgageot merged 1 commit intodocker:mainfrom
Conversation
Shorten Instructions() and tool descriptions across all builtin tools: shell, LSP, fetch, memory, think, tasks, deferred, and user_prompt. Remove redundant prose, verbose output format sections, and excessive examples. Retain essential examples for critical workflows (symbol search, references, shell heredocs, user_prompt schemas). Update corresponding tests to match reduced descriptions. Assisted-By: cagent
There was a problem hiding this comment.
Review Summary
This PR successfully reduces builtin tool prompt lengths while preserving essential information. The changes are focused on removing redundant prose, verbose output format sections, and excessive examples from Instructions() and tool descriptions across all builtin tools.
The edits maintain the key workflows and critical examples (symbol search, references, shell heredocs, user_prompt schemas) while making the documentation more concise. Test assertions have been appropriately updated to match the reduced descriptions.
No functional changes detected. All modifications are cosmetic documentation improvements that enhance readability without impacting tool behavior.
gtardif
left a comment
There was a problem hiding this comment.
small nit question, happy to merge as is anyway
|
|
||
| // Should mention the tools are stateless | ||
| assert.Contains(t, instructions, "stateless") | ||
| assert.Contains(t, instructions, "Stateless") |
There was a problem hiding this comment.
Nit: compare with toLower() to make this more resilient? (if we need this change, feels like a sign to me)
Shorten Instructions() and tool descriptions across all builtin tools: shell, LSP, fetch, memory, think, tasks, deferred, and user_prompt. Remove redundant prose, verbose output format sections, and excessive examples. Retain essential examples for critical workflows (symbol search, references, shell heredocs, user_prompt schemas). Update corresponding tests to match reduced descriptions.
Assisted-By: cagent