docs: fix C4 diagrams based on Simon Brown's review#276
Merged
rdmueller merged 1 commit intodocToolchain:mainfrom Feb 9, 2026
Merged
docs: fix C4 diagrams based on Simon Brown's review#276rdmueller merged 1 commit intodocToolchain:mainfrom
rdmueller merged 1 commit intodocToolchain:mainfrom
Conversation
Fixes based on unsolicited diagram review by the C4 model creator: - Level 2: File System moved inside system boundary as ContainerDb (it's dacli's data store per ADR-001, not an external system) - Level 2: Use LAYOUT_WITH_LEGEND() consistently across all diagrams - Level 3 MCP: Add Service Layer component, use ContainerDb for file system, add abstraction type in Container_Boundary label - Level 3 CLI: Move all shared components (Parsers, Index, File Handler) inside the container boundary for consistency with MCP - Remove fake "Level 3: Document Parsers" C4 component diagram (Document Parsers is a component, not a container — you can't zoom into components in C4). Replace with text description and comparison table under "Document Parser Architecture". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simon Brown (creator of the C4 model) reviewed our Building Block View diagrams and gave a 6/10. This PR addresses all four of his feedback points:
Level 2 — File System moved inside system boundary as
ContainerDb(it's dacli's data store per ADR-001, not an external system). Legend now consistent viaLAYOUT_WITH_LEGEND().Level 3 MCP — File System as
ContainerDbinstead ofSystem_Ext. Added abstraction type inContainer_Boundarylabel for clarity without relying on grey shades.Level 3 CLI — All shared components (Parsers, Index, File Handler) now inside the container boundary, consistent with the MCP Server diagram.
"Level 3: Document Parsers" removed — "Document Parsers" is a component, not a container. You can't zoom into components in C4. Replaced with a text-based "Document Parser Architecture" section with comparison table and class descriptions.
Ref: #272
Test plan
🤖 Generated with Claude Code