Skip to content

fix: elements help text lists incorrect element types#260

Merged
rdmueller merged 1 commit intodocToolchain:mainfrom
raifdmueller:fix/elements-help-types-259
Feb 7, 2026
Merged

fix: elements help text lists incorrect element types#260
rdmueller merged 1 commit intodocToolchain:mainfrom
raifdmueller:fix/elements-help-types-259

Conversation

@raifdmueller
Copy link
Collaborator

Summary

  • Replace outdated diagram element type with correct types: admonition, code, image, list, plantuml, table
  • Fixed in CLI help, MCP tool docstring, API models, API type mappings, and documentation specs
  • Added 5 tests verifying correct type listing and backward-compatible warning for diagram

Changes

  • src/dacli/cli.py - Updated --type help text
  • src/dacli/mcp_app.py - Updated get_elements docstring
  • src/dacli/api/models.py - Updated VALID_ELEMENT_TYPES and ElementItem field description
  • src/dacli/api/content.py - Updated ELEMENT_TYPE_TO_API and API_TYPE_TO_ELEMENT mappings, query description
  • src/docs/spec/02_api_specification.adoc - Updated Element data model and error example
  • src/docs/spec/03_acceptance_criteria.adoc - Updated Gherkin scenario to use plantuml
  • src/docs/50-user-manual/20-mcp-tools.adoc - Updated parameter description
  • tests/test_elements_help_types_259.py - New test file (5 tests)
  • tests/test_content_access_api.py - Updated existing test to use plantuml type

Test plan

  • 5 new tests for correct type listing in CLI help and MCP docstring
  • Full test suite: 642 tests pass
  • Lint clean (ruff check)

Fixes #259

🤖 Generated with Claude Code

Replace outdated 'diagram' type with correct types: admonition, code,
image, list, plantuml, table across CLI help, MCP docstring, API models,
API type mappings, and documentation specs.

Fixes docToolchain#259

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rdmueller rdmueller merged commit 83e53db into docToolchain:main Feb 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

elements --help lists incorrect element types (diagram instead of admonition/plantuml)

2 participants