Merged
Conversation
- Add .github/workflows/test.yml for automated testing on PRs - Run pytest and ruff check on every PR and push to main - Uses uv for dependency management - Fix: Pass attributes parameter to _parse_elements method Closes #23 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds automated CI testing via GitHub Actions and fixes a linting error in the AsciiDoc parser. The workflow runs on every push to main and on pull requests, executing both linting and test suites.
Changes:
- Add GitHub Actions workflow for automated testing with
uvdependency management - Fix bug where
attributesparameter wasn't passed to_parse_elementsmethod (ruff F821 error) - Improve code style with proper import ordering and whitespace cleanup in tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/test.yml |
New CI workflow that runs ruff linting and pytest on PRs and main branch pushes |
src/mcp_server/asciidoc_parser.py |
Fixes missing attributes parameter in _parse_elements call and removes problematic locals() check |
tests/test_asciidoc_parser.py |
Reorders imports to follow Python conventions and removes trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
uv sync --dev doesn't exist, need --extra dev for optional-dependencies Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds automated test execution on Pull Requests via GitHub Actions.
Changes
.github/workflows/test.ymlworkflowuvfor dependency managementruff checkfor lintingpytestfor testsattributesparameter to_parse_elementsmethod (was causing ruff F821 error)Workflow Steps
astral-sh/setup-uv@v4uv syncuv run ruff checkuv run pytestTest plan
Closes #23
🤖 Generated with Claude Code